candlerb commented on issue #5365: python API missing `is_read_compacted` in create_reader() URL: https://github.com/apache/pulsar/issues/5365#issuecomment-546945243 I made a fix, it's pretty simple (PR to follow). However I spotted another problem: ``` if reader_listener: conf.reader_listener(_listener_wrapper(reader_listener, schema)) ``` In the code you posted before, should ``` .def("message_listener", &ReaderConfiguration_setReaderListener, return_self<>()) ``` be changed to ``` .def("reader_listener", &ReaderConfiguration_setReaderListener, return_self<>()) ``` ? Or should the python code be changed to use `message_listener` instead?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
