merlimat commented on a change in pull request #5491: Fix message deduplicate
issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r340899288
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##########
@@ -76,6 +76,14 @@ default long getOriginalSequenceId() {
}
void completed(Exception e, long ledgerId, long entryId);
+
+ default long getLowestSequenceId() {
Review comment:
I don't see how these sequence ids relate to a `Topic`.
* What's the lowest sequenceId ? I think this only apply to 1 single batch.
* Sequence id are *per producer* anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
