sijie commented on a change in pull request #5515: [Transaction Coordinator] 
Bootstrap pulsar system namespace and create TC assign topic.
URL: https://github.com/apache/pulsar/pull/5515#discussion_r341284909
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
 ##########
 @@ -472,6 +472,11 @@ public Boolean get() {
             // Register heartbeat and bootstrap namespaces.
             this.nsService.registerBootstrapNamespaces();
 
+            // Register pulsar system namespaces
+            if (config.isTransactionCoordinatorEnabled()) {
+               
this.nsService.registerNamespace(NamespaceName.SYSTEM_NAMESPACE.toString(), 
false);
 
 Review comment:
   We might need to document this. If a user already has a Pulsar cluster (e.g. 
2.4.0), the user wants to upgrade to 2.5.0 to enable transaction. He/she has to 
create a `pulsar/system` namespace and the coordinator topic. So it might be 
making sense to add a command tool (similar as PulsarClusterMetadataSetup) to 
upgrade the cluster to enable transaction.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to