sijie commented on a change in pull request #82: Added a message id tracker for
acking messages that are batched.
URL: https://github.com/apache/pulsar-client-go/pull/82#discussion_r341911262
##########
File path: pulsar/impl_message.go
##########
@@ -18,30 +18,31 @@
package pulsar
import (
+ "math/big"
+ "strings"
+ "sync"
"time"
- "github.com/apache/pulsar-client-go/pkg/pb"
"github.com/golang/protobuf/proto"
-)
-func earliestMessageID() MessageID {
- return newMessageID(-1, -1, -1, -1)
-}
+ "github.com/apache/pulsar-client-go/pkg/pb"
+)
type messageID struct {
ledgerID int64
entryID int64
batchIdx int
partitionIdx int
+
+ tracker *ackTracker
Review comment:
Can you explain why adding `ackTracker` into the `messageID` structure?
1) logically I don't think it should belong to a `MessageID`.
2) This makes code sound like a hack solution. Is there another solution to
implement the tracker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
