wolfstudy opened a new pull request #5569: [Schema] [Pulsar Functions] Fix 
schema def build error with protobuf schema 
URL: https://github.com/apache/pulsar/pull/5569
 
 
   Signed-off-by: xiaolong.ran <[email protected]>
   
   Fixes #5566 
   
   ### Motivation
   
   In `newSchemaInstance` func, the properties param is `Collections.emptyMap()`
   
   ```
   case PROTOBUF:
       return ProtobufSchema.ofGenericClass(clazz, Collections.emptyMap());
   ```
   
   but in `build` of `SchemaDefinition`, we want put some things to map:
   
   ```
   properties.put(ALWAYS_ALLOW_NULL, this.alwaysAllowNull ? "true" : "false");
   ```
   
   
   
   ### Modifications
   
   Use `HashMap` instead of `Collections.emptyMap()`.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to