sijie commented on a change in pull request #5571: Add epoch for connection
handler to handle create producer timeout.
URL: https://github.com/apache/pulsar/pull/5571#discussion_r343092682
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -139,7 +140,9 @@ public String toString() {
@Override
public ConcurrentOpenHashSet<Producer> getProducers() {
- return producers;
+ ConcurrentOpenHashSet<Producer> result = new
ConcurrentOpenHashSet<>(16, 1);
Review comment:
oops. I didn't realize that there is a `getProducers` here. It is used in a
lot of places. hence it might be a performance problem if we changed to a hash
map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
