codelipenghui commented on a change in pull request #5571: Add epoch for
connection handler to handle create producer timeout.
URL: https://github.com/apache/pulsar/pull/5571#discussion_r343230102
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -139,7 +140,9 @@ public String toString() {
@Override
public ConcurrentOpenHashSet<Producer> getProducers() {
- return producers;
+ ConcurrentOpenHashSet<Producer> result = new
ConcurrentOpenHashSet<>(16, 1);
Review comment:
I have checked the used places of method `getProducers()`
Looks ok, two places used it, handle backlog exceeded backlog and prometheus
metrics aggregator, others are unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
