addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552048442 Perhaps I am missing something, but I think there is a mismatch here. The `FunctionRuntimeManager` can manage the creation of the `RuntimeCustomizer`, but it couldn't be eagerly in it's constructor or initialization methods. It would need to be during the `addAssignment` and `updateAssignment` methods as that is the first place where we get the function details. In other words, the `FunctionRuntimeManager`'s lifecycle is such that it managed multiple functions and would need to have a factory method to create a `RuntimeCustomizer` for each function. This is essentially the problem with `FunctionAuthProvider` as it currently is created once for the whole runtime and instead needs to be per function. Perhaps the `RuntimeCustomizer` could be responsible for the lifecycle of the `FunctionAuthProvider` as well, but their lifecycles would seem intertwined. Let me know if I am missing something.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
