sijie commented on a change in pull request #5613: [PIP-50] Package management implementation (part-1) URL: https://github.com/apache/pulsar/pull/5613#discussion_r344682954
########## File path: pulsar-package-management/src/main/java/pkg/management/storage/bk/BKStorage.java ########## @@ -0,0 +1,219 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package pkg.management.storage.bk; + +import com.google.common.annotations.VisibleForTesting; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.CompletableFuture; +import lombok.extern.slf4j.Slf4j; +import org.apache.commons.lang3.StringUtils; +import org.apache.distributedlog.AppendOnlyStreamReader; +import org.apache.distributedlog.AppendOnlyStreamWriter; +import org.apache.distributedlog.DistributedLogConfiguration; +import org.apache.distributedlog.api.DistributedLogManager; +import org.apache.distributedlog.api.namespace.Namespace; +import org.apache.distributedlog.api.namespace.NamespaceBuilder; +import pkg.management.PkgStorage; +import pkg.management.PkgStorageConfig; + +// Using bookKeeper to store the package +@Slf4j +public class BKStorage implements PkgStorage { Review comment: BKStorage is an ambiguous name. When you are implementing an interface, you can just add "BK" prefix to the interface name to indicate it is a "BK" implementation of that interface. Thus, "BKPackageStorage" is much better than "BKStorage". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
