merlimat commented on a change in pull request #5599: [pulsar-broker] close
managed-ledgers before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#discussion_r344910706
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1153,9 +1153,10 @@ public void checkTopicNsOwnership(final String topic)
throws RuntimeException {
* Unload all the topic served by the broker service under the given
service unit
*
* @param serviceUnit
+ * @param force don't wait for clients to disconnect and forcefully close
managed-ledger
* @return
*/
- public CompletableFuture<Integer> unloadServiceUnit(NamespaceBundle
serviceUnit) {
+ public CompletableFuture<Integer> unloadServiceUnit(NamespaceBundle
serviceUnit, boolean force) {
Review comment:
Same here, the `force` meaning is not evident when calling this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
