sijie commented on issue #5557: [Schema]Add SchemaDisabled for schema URL: https://github.com/apache/pulsar/pull/5557#issuecomment-552770595 > That was the point that "disabled" is not clear enough to convey what's being disabled. How about naming it `SchemaInfoDisabled > Why not? To me it seems more of a producer/consumer property: the "schema" is the same, but you don't want to pass the schema info to broker. I think adding a wrapper to return `null` schema info to bypass uploading schema info is a more extensible solution rather than spreading the setting across different places. You can add it for producer and consumer for now. but if the schema is used in somewhere else in the future, we have to end up adding the setting across the codebase. It is really hard to maintain. > In addition to the Javadoc which is still missing and the discussion on wether to have it as a wrapper or as an option, it would be good to have a description of how this Schema is going to be used (eg: the "motivation" for adding it). @tuteng can update those once we reach an agreement on this pull request. 1. Should we go down the wrapper approach or configuration approach? 2. If we go down the wrapper approach, what is the name? `SchemaDisabled`, `SchemaInfoDisabledSchema`, or any other better name.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
