rdhabalia commented on a change in pull request #5599: [pulsar-broker] close
managed-ledgers before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#discussion_r345968969
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##########
@@ -110,7 +110,7 @@ default long getOriginalSequenceId() {
CompletableFuture<Void> checkReplication();
- CompletableFuture<Void> close();
+ CompletableFuture<Void> close(boolean force);
Review comment:
> Can't we just consider "force" the only approach?
No, because first we want to close topic gracefully by closing all clients
first and then close managed-ledger. If things don't get closed gracefully then
close topic forcefully by closing managed-ledger before giving up ownership of
the bundle. So, we need both behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
