sijie commented on issue #5513: Publish rate limit on broker to avoid OOM URL: https://github.com/apache/pulsar/issues/5513#issuecomment-558405159 > all threads are going to do rate limit using one counter and that could be bottleneck as well so, one wants to avoid it as well. The current implementation of RateLimiter is using LongAdder for counting the bytes and msgs. A LongAdder maintains multiple cells for counters. They are only aggregated when `sum` is called. The `sum` is called when the monitor, which is done periodically in the background thread. I am not sure how this would be a bottleneck. LongAdder is also used for other metrics. Shouldn't they be all concerned as well?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
