zymap commented on issue #5714: Add more info in the error messages URL: https://github.com/apache/pulsar/pull/5714#issuecomment-558706669 @sijie There are two ways when we threw an Exception. One is we get an exception and throw it out. ``` future.exceptionally(e -> { anotherFuture.completeExceptionally(e) }) ``` Another is we wrap the exception with the `PulsarClientException`. ``` future.exceptionally(e -> { anotherFuture.completeExceptinoally(new PulsarClientException()) }) ``` If the exception belongs to the second one, I can add the info message easily. Otherwise, I think it has a risk to update the Exception If I don't know the exception is caught by others for retrying or do something others. How do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
