tuteng commented on issue #5738: [Pulsar Client Tools]Support generate 
documentation of pulsar admin cli automatically
URL: https://github.com/apache/pulsar/pull/5738#issuecomment-559637809
 
 
   Thank you for your suggestion. The situation you mentioned is my initial 
implementation plan. However, when I tested it, I found that different command 
objects `jcommand` was used in the PulsarAdminTool and CmdBase.
   
   PulsarAdminTool:
   
https://github.com/apache/pulsar/blob/master/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java#L87
   CmdBase:
   
https://github.com/apache/pulsar/blob/master/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBase.java#L38
   
   
   All the child commands were inherited from the class `CmdBase`. In 
subclasses such as `CmdTopics`, we cannot get the `commandMap` object. 
Therefore, it may be necessary to pass down the `commandmap` object and the 
`jcommand` object of `PulsarAdminTool`. therefore, it is necessary to add some 
logic to the `PulsarAdmintool`. I am not sure if my understanding is correct. I 
hope to get your reply, but I will try this implementation as much as possible.
   
   @sijie 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to