tuteng commented on a change in pull request #5767: Support batch authorization
of partitioned topic
URL: https://github.com/apache/pulsar/pull/5767#discussion_r352285204
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -369,6 +373,24 @@ protected void internalRevokePermissionsOnTopic(String
role) {
log.error("[{}] Failed to revoke permissions for topic {}",
clientAppId(), topicUri, e);
throw new RestException(e);
}
+
+ }
+
+ protected void internalRevokePermissionsOnTopic(String role) {
+ // This operation should be reading from zookeeper and it should be
allowed without having admin privileges
+ validateAdminAccessForTenant(namespaceName.getTenant());
+ validatePoliciesReadOnlyAccess();
+
+ PartitionedTopicMetadata meta = getPartitionedTopicMetadata(topicName,
true, false);
Review comment:
Same as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
