sijie commented on a change in pull request #5714: Add more info in the error
messages
URL: https://github.com/apache/pulsar/pull/5714#discussion_r352359003
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1466,7 +1480,10 @@ public void seek(long timestamp) throws
PulsarClientException {
seekFuture.complete(null);
}).exceptionally(e -> {
log.error("[{}][{}] Failed to reset subscription: {}", topic,
subscription, e.getCause().getMessage());
- seekFuture.completeExceptionally(e.getCause());
+ seekFuture.completeExceptionally(
+ new PulsarClientException.WrapperException(
Review comment:
I am not sure WrapperException is the right fix here. because it will change
the client behavior. for example, if a client used to handle exeception A, now
we are throwing a WrapperException of A.
We should reconstruct a A with an updated error message and its stack trace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
