codelipenghui commented on a change in pull request #5782: Modify the logical 
in producer carry a schema to connect broker with isAllowAutoUpdateSchema. 
URL: https://github.com/apache/pulsar/pull/5782#discussion_r353524616
 
 

 ##########
 File path: 
pulsar-broker/src/test/java/org/apache/pulsar/schema/compatibility/SchemaCompatibilityCheckTest.java
 ##########
 @@ -267,6 +269,23 @@ public void 
testIsAutoUpdateSchema(SchemaCompatibilityStrategy schemaCompatibili
         assertEquals(personTwo.id, 2);
         assertEquals(personTwo.name, "Lucy");
 
+        producer.close();
+        consumerTwo.close();
+
+        producer = producerThreeBuilder.create();
+        consumerTwo = comsumerBuilder.subscribe();
+
+        
admin.namespaces().setIsAllowAutoUpdateSchema(namespaceName.toString(), false);
 
 Review comment:
   Set schema auto update strategy need before producer creation, because we do 
the schema compatibility check when create a new producer or consumer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to