codelipenghui commented on a change in pull request #5570: Transaction log 
implemention
URL: https://github.com/apache/pulsar/pull/5570#discussion_r353572089
 
 

 ##########
 File path: 
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/TransactionLog.java
 ##########
 @@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.transaction.coordinator;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.apache.bookkeeper.mledger.AsyncCallbacks;
+import org.apache.pulsar.common.api.proto.PulsarApi;
+import org.apache.pulsar.transaction.impl.common.TxnID;
+
+/**
+ * A log interface for transaction to read and write transaction operation.
+ */
+public interface TransactionLog {
+
+
+    /**
+     * Replay transaction log to load the transaction map.
+     *
+     * @param txnMetaMap the map of transaction metadata store to load
+     * @param sequenceId the sequence id for transaction metadata store to 
create new transaction
+     * @param replayCallback the call back for replaying the transaction log
+     */
+    void replayAsync(ConcurrentMap<TxnID, TxnMeta> txnMetaMap,
+                AtomicLong sequenceId, ReplayCallback replayCallback);
+
+    /**
+     * Read the entry from bookkeeper.
+     *
+     * @param numberOfEntriesToRead the number of reading entry
+     * @param callback the callback to executing when reading entry async 
finished
+     */
+    void readAsync(int numberOfEntriesToRead, 
AsyncCallbacks.ReadEntriesCallback callback, Object ctx);
 
 Review comment:
   Both write read and replay should use TransactionMetadataEntry not Entry or 
some other types.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to