sijie commented on a change in pull request #5802: Provide raw counters metrics
(#5735)
URL: https://github.com/apache/pulsar/pull/5802#discussion_r355198721
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1297,6 +1297,11 @@
doc = "If true, export consumer level metrics otherwise namespace
level"
)
private boolean exposeConsumerLevelMetricsInPrometheus = false;
+ @FieldContext(
+ category = CATEGORY_METRICS,
+ doc = "If true, export raw counter topic level metrics"
+ )
+ private boolean exposeCounterTopicMetricsInPrometheus = false;
Review comment:
I don't think we need this flag.
if `exposeTopicLevelMetricsInPrometheus` is true, we can expose this
counter. there should be no penalty to do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
