Jim-Lambert-Bose opened a new pull request #115: [Issue #112] Fix installation 
of go module
URL: https://github.com/apache/pulsar-client-go/pull/115
 
 
   <--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the 
pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull 
request.
       Skip *component* if you are unsure about which is the best component. 
E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and 
this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
   
   Fixes #<xyz>
   
   *(or if this PR is one task of a github issue, please add `Master Issue: 
#<xyz>` to link to the master issue.)*
   
   Master Issue: #<xyz>
   
   ### Motivation
   
   Fix the installation of the client's go module: 
github.com/apache/pulsar-client-go
   With this change, no one can install the client using the standard `go get` 
tool chain
   
   ### Modifications
   
   Added a no_code.go source file to the root directory.  This is required the 
module currently won't install because the only source in the root directory is 
licence_test.go (which walks the source tree looking for license txt in each 
file).
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API:  no
     - The schema: no 
     - The default values of configurations: no
     - The wire protocol: no
   
   ### Documentation
   
   No need for documentation besides the comments in the no_code.go source 
file.  If the project changes how licensing is checked, then this change can be 
reverted.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to