Jim-Lambert-Bose opened a new pull request #119: [Issue 118][client_impl.go] fix race condition when accessing client.handlers URL: https://github.com/apache/pulsar-client-go/pull/119 <-- ### Contribution Checklist - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number. Skip *Issue XYZ* if there is no associated github issue for this pull request. Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)* Fixes #<xyz> *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)* Master Issue: #<xyz> ### Motivation fix race condition caused by writing to map in multiple goroutines ### Modifications Created new internal type: ClientHandlers which encapsulates a sync.Mutex to make read/writes to clients.handlers concurrent safe. ### Verifying this change This change added tests and can be verified as follows: just run: `go test -timeout 30s github.com/apache/pulsar-client-go/pulsar/internal -run "^(TestClientHandlers)$"` ### Documentation - Does this pull request introduce a new feature? no
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
