cckellogg commented on issue #5843: Duplicate flags when running bin/pulsar bookie URL: https://github.com/apache/pulsar/issues/5843#issuecomment-565746933 @jiazhai my main concern is the current behavior was to use `PULSAR_MEM` to set the memory for bookies when running `bin/pulsar` now that is not the case so all users that upgrade to a newer version will have to change their configuration before upgrading. Also, this is provides duplicate flags which is confusing regardless if the right most one takes. In my opinion bkenv.sh should only be applied to `bin/bookkeeper` and the pulsar_env.sh should only be used in the `bin/pulsar` and other `bin/pulsar-*` scripts. To me loading both is confusing and can lead to unexpected errors or behavior. Why is `PULSAR_MEM` not a good way to set the memory? `PULSAR_MEM` is used to set the memory for all commands (zookeeper, presto, function-worker, etc..) in the `bin/pulsar` script. It seems clear to me if I run `bin/pulsar` or any `bin/pulsar-*` script I control the memory with `PULSAR_MEM`. #5675 changes this and makes it inconsistent with how everything else works and that in my opinion is confusing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
