jiazhai commented on issue #5872: [broker] Allow for namespace default of 
offload threshold
URL: https://github.com/apache/pulsar/pull/5872#issuecomment-566896709
 
 
   Thanks @addisonj for the detailed explanation. Comparing with "Long", your 
later change 
https://github.com/instructure/pulsar/commit/a5bb666d5bb2f33099e639672e3c2e56fef2c03d
  is better from my point of view. as you suggested we could choose another -2 
for this case.
   regarding the test, could we reuse 
[NamespacesTest.java](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespacesTest.java)
 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to