sijie commented on issue #5900: [pulsar-flink]Cache Pulsar client to make it 
shared among tasks in a process
URL: https://github.com/apache/pulsar/pull/5900#issuecomment-568630606
 
 
   @yjshen 
   
   there are multiple checkstyle violations: 
   ```
   2019-12-20\T\03:15:49.583 [INFO] --- maven-checkstyle-plugin:3.0.0:check 
(check-style) @ pulsar-flink ---
   2019-12-20\T\03:15:50.834 [INFO] There are 7 errors reported by Checkstyle 
6.18 with ../buildtools/src/main/resources/pulsar/checkstyle.xml ruleset.
   2019-12-20\T\03:15:50.837 [ERROR] 
src/main/java/org/apache/flink/streaming/connectors/pulsar/CachedPulsarClient.java:[8]
 (imports) ImportOrder: Import 
org.apache.pulsar.client.api.PulsarClientException appears after other imports 
that it should precede
   2019-12-20\T\03:15:50.838 [ERROR] 
src/main/java/org/apache/flink/streaming/connectors/pulsar/CachedPulsarClient.java:[13]
 (imports) ImportOrder: Import java.util.concurrent.ExecutionException appears 
after other imports that it should precede
   2019-12-20\T\03:15:50.839 [ERROR] 
src/main/java/org/apache/flink/streaming/connectors/pulsar/CachedPulsarClient.java:[15]
 (javadoc) JavadocType: Missing a Javadoc comment.
   2019-12-20\T\03:15:50.839 [ERROR] 
src/main/java/org/apache/flink/streaming/connectors/pulsar/CachedPulsarClient.java:[24]
 (sizes) LineLength: Line is longer than 120 characters (found 150).
   2019-12-20\T\03:15:50.840 [ERROR] 
src/main/java/org/apache/flink/streaming/connectors/pulsar/CachedPulsarClient.java:[34]
 (sizes) LineLength: Line is longer than 120 characters (found 147).
   2019-12-20\T\03:15:50.840 [ERROR] 
src/main/java/org/apache/flink/streaming/connectors/pulsar/CachedPulsarClient.java:[41]
 (sizes) LineLength: Line is longer than 120 characters (found 123).
   2019-12-20\T\03:15:50.841 [ERROR] 
src/main/java/org/apache/flink/streaming/connectors/pulsar/CachedPulsarClient.java:[45]
 (sizes) LineLength: Line is longer than 120 characters (found 128).
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to