congbobo184 commented on a change in pull request #5915: Allow to
enable/disable delayed delivery for messages on namespace
URL: https://github.com/apache/pulsar/pull/5915#discussion_r362728240
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Namespaces.java
##########
@@ -1152,7 +1153,69 @@ void clearNamespaceBundleBacklogForSubscription(String
namespace, String bundle,
*/
void setEncryptionRequiredStatus(String namespace, boolean
encryptionRequired) throws PulsarAdminException;
- /**
+ /**
+ * Get the delayed delivery messages for all topics within a namespace.
+ * <p>
+ * If disabled, messages will be immediately delivered and there will
+ * be no tracking overhead.
+ * <p>
+ * Request example:
+ *
+ * <pre>
+ * <code>
+ * {
+ * "tickTime" : 1000, // Enable or disable delayed delivery for
messages on a namespace
+ * "active" : true, // The tick time for when retrying on delayed
delivery messages
+ * }
+ * </code>
+ * </pre>
+ *
+ * @param namespace
+ * Namespace name
+ * @return delayedDeliveryPolicies
+ * Whether to enable the delayed delivery for messages.
+ *
+ * @throws NotAuthorizedException
+ * Don't have admin permission
+ * @throws NotFoundException
+ * Namespace does not exist
+ * @throws PulsarAdminException
+ * Unexpected error
+ */
+ DelayedDeliveryPolicies getDelayedDelivery(String namespace) throws
PulsarAdminException;
+
+ /**
+ * Set the delayed delivery messages for all topics within a namespace.
+ * <p>
+ * If disabled, messages will be immediately delivered and there will
+ * be no tracking overhead.
+ * <p>
+ * Request example:
+ *
+ * <pre>
+ * <code>
+ * {
+ * "tickTime" : 1000, // Enable or disable delayed delivery for
messages on a namespace
+ * "active" : true, // The tick time for when retrying on delayed
delivery messages
Review comment:
are the two notes reversed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
