cckellogg commented on a change in pull request #158: Topic reader
implementation
URL: https://github.com/apache/pulsar-client-go/pull/158#discussion_r362986826
##########
File path: pulsar/consumer_partition.go
##########
@@ -109,9 +129,11 @@ func newPartitionConsumer(parent Consumer, client
*client, options *partitionCon
eventsCh: make(chan interface{}, 3),
queueSize: int32(options.receiverQueueSize),
queueCh: make(chan []*message,
options.receiverQueueSize),
+ startMessageID: options.startMessageID,
connectedCh: make(chan struct{}),
messageCh: messageCh,
closeCh: make(chan struct{}),
+ clearQueueCh: make(chan func(id *messageID)),
Review comment:
Are we ok with this channel being unbuffered?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
