jiazhai commented on issue #5992: Helm deployment fails to deploy properly URL: https://github.com/apache/pulsar/issues/5992#issuecomment-570991262 @ckdarby as @merlimat mentioned, would you please help try the commits before 23ae5ec ? , such as f95c71f21aae9e8299597295ccb2bc6954d82ae5 or 88fc454173af94d33986e608e94037db556a9226 ``` commit 23ae5eca871bde2599f86cebfe9971cb08584bf9 Author: Ali Ahmed <[email protected]> Date: Sat Jan 4 18:30:34 2020 -0800 Make docker files consistent. (#5949) Allow volume override for docker commands with env variable, this allows the scripts to work in dind environments. commit f95c71f21aae9e8299597295ccb2bc6954d82ae5 Author: Matteo Merli <[email protected]> Date: Sat Jan 4 04:25:04 2020 -0800 Make standalone to advertise "localhost" to avoid failure when hostname is not resolvable (#5856) ### Motivation The standalone service is failing to startup when the hostname is not resolvable to an IP. This is common in laptops. The reason is that the function worker in standalone is trying to connect to the advertised address rather than "localhost". To fix this, we should make the standalone to always advertise "localhost" as the the broker address. This is ok because in any case the standalone treats the advertisement as the pulsar proxy, in that it forces the clients to always go through the same service url, so a client connecting from a different host won't have problems. commit 88fc454173af94d33986e608e94037db556a9226 Author: Jia Zhai <[email protected]> Date: Fri Jan 3 23:47:21 2020 +0800 fix reader builder clone error (#5923) Motivation In reader builder, clone() method does not clone the config, and will cause error once we call a builder.clone() concurrently to create readers. This PR mainly try to fix this issue. Modifications use conf.clone(), to make sure conf is cloned. add test to verify it. fix other small issues, like get() methods, and access level, make it align with consumer/producer builder. Verifying this change ut passed. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
