zzzming commented on a change in pull request #5990: [Issue 5969] prevent redelivery of acked batch message at the client api URL: https://github.com/apache/pulsar/pull/5990#discussion_r363448644
########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchAckedTracker.java ########## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.client.impl; + +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; + +import com.google.common.annotations.VisibleForTesting; + +import org.apache.pulsar.client.api.MessageId; + +/** + * Tracks any partial acked batches and its acked messages + * This will prevent acked message redelivery to the client only at the client API level. + * This class does not track batch with all acked message. We trust broker won't deliver again. + */ +class BatchAckedTracker { + + // a map of partial acked batch and its messages already acked + @VisibleForTesting + Map<String, Set<BatchMessageIdImpl>> ackedBatches = new HashMap<String, Set<BatchMessageIdImpl>>(); Review comment: Currently it uses Set of integer to track the acked batch. So the memory footprint is small. I think it can even use bitset like the BatchAcker. I try to keep this isolated and testable from AcknowledgmentGroupingTracker. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
