wolfstudy commented on a change in pull request #167: res channel causes
connection.Run() to block When request timeout occuers
URL: https://github.com/apache/pulsar-client-go/pull/167#discussion_r364070356
##########
File path: pulsar/internal/rpc_client.go
##########
@@ -90,7 +90,7 @@ func (c *rpcClient) Request(logicalAddr *url.URL,
physicalAddr *url.URL, request
*RPCResult
error
}
- ch := make(chan Res)
+ ch := make(chan Res, 1)
Review comment:
```suggestion
ch := make(chan Res, 10)
```
Normally we use 10 as the buffer size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
