vzhikserg commented on a change in pull request #6028: [Issue 5690][pulsar-io] 
Make type name of Elasticsearch sink connector configurable.
URL: https://github.com/apache/pulsar/pull/6028#discussion_r365768546
 
 

 ##########
 File path: site2/docs/io-elasticsearch-sink.md
 ##########
 @@ -16,21 +16,26 @@ The configuration of the ElasticSearch sink connector has 
the following properti
 |------|----------|----------|---------|-------------|
 | `elasticSearchUrl` | String| true |" " (empty string)| The URL of elastic 
search cluster to which the connector connects. |
 | `indexName` | String| true |" " (empty string)| The index name to which the 
connector writes messages. |
+| `typeName` | String | false | "_doc" | The type name to which the connector 
writes messages to. <br><br> The value should be set explicitly to a valid type 
name other than "_doc" for Elasticsearch version before 6.2, and left to 
default otherwise. |
 | `indexNumberOfShards` | int| false |1| The number of shards of the index. |
 | `indexNumberOfReplicas` | int| false |1 | The number of replicas of the 
index. |
 | `username` | String| false |" " (empty string)| The username used by the 
connector to connect to the elastic search cluster. <br><br>If `username` is 
set, then `password` should also be provided. |
 | `password` | String| false | " " (empty string)|The password used by the 
connector to connect to the elastic search cluster. <br><br>If `username` is 
set, then `password` should also be provided.  |
 
-### Example
+## Example
 
 Review comment:
   OK, it is fine if you wanted to make it consistent with description of other 
connectors 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to