devinbost commented on a change in pull request #6031: [Issue 4175] 
[pulsar-function-go] Add Go Function heartbeat (and gRPC service) for 
production usage
URL: https://github.com/apache/pulsar/pull/6031#discussion_r367031387
 
 

 ##########
 File path: pulsar-function-go/pf/instance_test.go
 ##########
 @@ -0,0 +1,93 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package pf
+
+import (
+       "github.com/stretchr/testify/assert"
+       "strconv"
+       "testing"
+       "time"
+)
+
+
+func testProcessSpawnerHealthCheckTimer(tkr *time.Ticker, lastHealthCheckTs 
int64, expectedHealthCheckInterval int32, counter *int ){
 
 Review comment:
   This change breaks the test because the counter variable doesn't propagate 
as needed for the assertion. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to