merlimat commented on a change in pull request #176: PIP-55: Refresh auth
credentials
URL: https://github.com/apache/pulsar-client-go/pull/176#discussion_r369125731
##########
File path: pulsar/internal/connection.go
##########
@@ -36,6 +36,14 @@ import (
"github.com/apache/pulsar-client-go/pulsar/internal/pb"
)
+const (
+ // TODO: Find a better way to embed the version in the library code
Review comment:
Problem is that we're shipping this as a library, so I guess the version
file is not going to be bundled. Anyway, as a start we could go by with
remembering to update the version string in source code, until we find a better
solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
