ivankelly commented on a change in pull request #6128: Fix broker client tls 
settings error
URL: https://github.com/apache/pulsar/pull/6128#discussion_r369988551
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
 ##########
 @@ -873,12 +873,16 @@ public synchronized PulsarClient getClient() throws 
PulsarServerException {
                 ClientBuilder builder = PulsarClient.builder()
                     .serviceUrl(this.getConfiguration().isTlsEnabled()
                                 ? this.brokerServiceUrlTls : 
this.brokerServiceUrl)
-                    .enableTls(this.getConfiguration().isTlsEnabled())
-                    
.allowTlsInsecureConnection(this.getConfiguration().isTlsAllowInsecureConnection())
-                    
.tlsTrustCertsFilePath(this.getConfiguration().getTlsCertificateFilePath());
+                    .enableTls(this.getConfiguration().isTlsEnabled());
+
+                if (this.getConfiguration().isBrokerClientTlsEnabled()) {
+                    
builder.allowTlsInsecureConnection(this.getConfiguration().isTlsAllowInsecureConnection());
+                    
builder.tlsTrustCertsFilePath(this.getConfiguration().getBrokerClientTrustCertsFilePath());
 
 Review comment:
   Generally the cacert should be the same. What scenario let you to this 
problem?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to