EugenDueck commented on issue #5950: [Issue 5927][Pulsar Client] Change the time unit of `patternAutoDiscoveryPeriod to seconds URL: https://github.com/apache/pulsar/pull/5950#issuecomment-578082302 +1 I was just about to submit my own PR that changes `Math.min` to `Math.max` - when I realized this PR, and that it contains the fix. > Of course, the proper solution would be to have the broker notifying clients whenever there are new topics. I agree, and if this is actually realistic (I have not seen enough of the pulsar code base yet to make that call) I would even volunteer to implement this, because it is something that I would like to have, as the use case I have started to play with has tens of thousands of topics in a single namespace, i.e. all these topics are subject to multi-topic pattern subscription. And for that, a push notification for topic additions and removals would seem much more lightweight than having to pull, say, 20 thousand topic names every second or so, even when there aren't (m)any changes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
