tmemenga opened a new pull request #6160: [helm-chart] add missing check to 
dashboard-ingress
URL: https://github.com/apache/pulsar/pull/6160
 
 
   ### Motivation
   
   if you deploy pulsar using the helm chart and disable monitoring with
   
   ```
   extras:
     dashboard: no
   
   ```
   
   but you have the ingress of the dashboard set to true
   
   ```
   dashboard:
     ingress:
       enabled: true
   ```
        
   
   the helm chart will create an ingress that points to a non-existing service 
because the dashboard itself was not deployed.
   
   
   ### Modifications
   
   I've added the same check that is already in place in dashboard-service and 
dashboard-deployment
   
   ### Verifying this change
   
   I dont know of any automated tests, i tested it manually. In the end it's 
the same "if" that is already in place in dashboard-service and 
dashboard-deployment
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   Affects deployment via helm chart. An unwanted ingress object is suppressed.
   
   ### Documentation
   
    no documentation need
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to