rdhabalia commented on a change in pull request #6139: [pulsar-kafka] support
block-producer on queue-full with sendTimeOut configuration
URL: https://github.com/apache/pulsar/pull/6139#discussion_r372610086
##########
File path:
pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/producer/PulsarKafkaProducer.java
##########
@@ -77,6 +78,14 @@
private List<ProducerInterceptor<K, V>> interceptors;
private final Properties properties;
+
+ public static class Config {
+ /**
+ * send operations will immediately fail with {@link
ProducerQueueIsFullError} when there is no space left in
+ * pending queue.
+ **/
+ public static final String BLOCK_IF_PRODUCER_QUEUE_FULL =
"block.if.producer.queue.full";
Review comment:
>> Does this seem to be a special config setting that only works for pulsar
Kafka producer?
Yes.
>> Can you please document this behavior?
Yes, added. can you please review it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
