codelipenghui commented on a change in pull request #6190: Ccorrected the
method name for source implementation
URL: https://github.com/apache/pulsar/pull/6190#discussion_r374116442
##########
File path: site2/docs/io-develop.md
##########
@@ -24,7 +24,7 @@ You can develop Pulsar source connectors and sink connectors.
### Source
Developing a source connector is to implement the {@inject:
github:`Source`:/pulsar-io/core/src/main/java/org/apache/pulsar/io/core/Source.java}
-interface, which means you need to implement the {@inject:
github:`open`:/pulsar-io/core/src/main/java/org/apache/pulsar/io/core/Source.java#L33}
method and the {@inject:
github:`record`:/pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Record.java#L28}
method.
+interface, which means you need to implement the {@inject:
github:`open`:/pulsar-io/core/src/main/java/org/apache/pulsar/io/core/Source.java#L33}
method and the {@inject:
github:`read`:/pulsar-io/core/src/main/java/org/apache/pulsar/io/core/Source.java#L41}
method.
Review comment:
Maybe we'd better remove the line indicator, because it might be changed.
Such like:
```
interface, which means you need to implement the open method and read method
in {@inject:
github:`open`:/pulsar-io/core/src/main/java/org/apache/pulsar/io/core/Source.java}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
