sijie commented on a change in pull request #6192: [deployement] make kubernetes yamls for aws operational URL: https://github.com/apache/pulsar/pull/6192#discussion_r374248370
########## File path: deployment/kubernetes/aws/proxy.yaml ########## @@ -23,10 +23,11 @@ metadata: name: pulsar-proxy-config data: PULSAR_MEM: "\" -Xms4g -Xmx4g -XX:MaxDirectMemorySize=4g\"" - PULSAR_PREFIX_brokerServiceURL: pulsar://broker:6650 - PULSAR_PREFIX_brokerWebServiceURL: http://broker:8080 - PULSAR_PREFIX_clusterName: pulsar-eks - + brokerServiceURL: pulsar://broker:6650 + brokerWebServiceURL: http://broker:8080 + clusterName: us-east + zookeeperServers: zk-0.zookeeper,zk-1.zookeeper,zk-2.zookeeper Review comment: I think you can just use the headless service name for `zookeeperServers` and `configurationStoreServers`. You don't need to write down all the pods here. because this will not work if people deploy a zookeeper with less than 3 pods. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
