hjohannsen commented on issue #6135: Unable to deploy on GKE, blocked at 
bookie.yaml step
URL: https://github.com/apache/pulsar/issues/6135#issuecomment-583382637
 
 
   @jiazhai, thanks for the hint! Sure I can help verify. 
   
   Just to make sure I fully understand how it's _supposed_ to work:
   
   **Background**
   I was trying to set up Pulsar with EKS, simply following the instructions in 
["Deploying Pulsar on 
Kubernetes"](https://pulsar.apache.org/docs/v1.22.0-incubating/deployment/Kubernetes/).
   For that purpose I cloned the Pulsar repo and copied the source files from 
`deployment/kubernetes/aws`. At that time, the `.yaml` files had the 
`PULSAR_PREFIX_` introducing most of the properties in the `ConfigMap`.
   From the 
[apply-config-from-env.py](https://github.com/apache/pulsar/blob/master/docker/pulsar/scripts/apply-config-from-env.py)
 script, I inferred that the script wouldn't apply the settings to properties 
that were _already set_ in the relevant config file (in the Docker container). 
Because of the prefix.
   Given that constellation, you would have to
   - omit the prefix for properties already defined in the config,
   - add the prefix for new properties absent from the config. 
   
   **Recent Changes**
   Looking at the history of, say `bookkeeper.yaml`, I see that the prefix was 
added consistently in `d74c1acb` (#5790) and removed again in `d631156d` (Issue 
#6192).  
   
   Nothing changed in  
[apply-config-from-env.py](https://github.com/apache/pulsar/blob/master/docker/pulsar/scripts/apply-config-from-env.py).
 So I still need to add the prefix to set properties that aren't preconfigured 
in the config file.
   
   **Question**
   Am I right in assuming that I shouldn't need to worry, at all, about 
settings that aren't preconfigured in the config from the Docker image? I only 
ever need to overwrite existing properties without ever adding a prefix?
   (I'd be totally fine with that.)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to