addisonj commented on issue #6233: [authentication] Validate tokens for binary connections URL: https://github.com/apache/pulsar/pull/6233#issuecomment-583511017 correct. It fails in the JWT validation with an NPE and leaves a lot of chattery logs. I don't believe this will actually makes the logs be less noisy as it still throws an exception that is logged, but I figured this is still much better than an NPE On Thu, Feb 6, 2020 at 6:05 PM Matteo Merli <[email protected]> wrote: > Currently, binary connects aren't checked to see if they provide a token. > > So it results in NPE, though the client is still not being allowed in, > right? > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/pulsar/pull/6233?email_source=notifications&email_token=AAE3LA2D3VLZTA4GEIQIRT3RBSXURA5CNFSM4KQSLQKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELBLOSY#issuecomment-583186251>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAE3LA4KRQQB6DN2ZBBMVEDRBSXURANCNFSM4KQSLQKA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
