fantapsody commented on issue #3733: support Pattern subscribe in kafka compat 
client
URL: https://github.com/apache/pulsar/issues/3733#issuecomment-583652156
 
 
   It seems several places in `PulsarKafkaConsumer` are affected In order to 
use `consumerBuilder.topicsPattern(pattern)` for subscription, like 
messageId/offset management/seeking/commit, consumer management, etc. And maybe 
we should also reimplement the multi-topic subscription using that provided by 
the underlying pulsar client? That may simplify the implementation as a whole, 
but need more work and tests than expected.
   
https://github.com/apache/pulsar/blob/54b39e64f361a2ed5242259e04505bcfc66c1c8a/pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java#L240

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to