sijie commented on a change in pull request #6187: [Issue 5904]Support `unload`
all partitions of a partitioned topic
URL: https://github.com/apache/pulsar/pull/6187#discussion_r376920003
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -655,12 +655,56 @@ protected void
internalDeletePartitionedTopic(AsyncResponse asyncResponse, boole
});
}
- protected void internalUnloadTopic(boolean authoritative) {
+ protected void internalUnloadTopic(AsyncResponse asyncResponse, boolean
authoritative) {
log.info("[{}] Unloading topic {}", clientAppId(), topicName);
if (topicName.isGlobal()) {
validateGlobalNamespaceOwnership(namespaceName);
}
- unloadTopic(topicName, authoritative);
+
+ PartitionedTopicMetadata partitionMetadata =
getPartitionedTopicMetadata(topicName, authoritative, false);
Review comment:
Yes. we need to make sure this method is also implemented in an async way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
