sijie commented on a change in pull request #6297: [Issue 4612][proxy] Fix
proxy to forward V3 API request to functions worker cluster
URL: https://github.com/apache/pulsar/pull/6297#discussion_r378489905
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/AdminProxyHandler.java
##########
@@ -260,8 +260,13 @@ protected String rewriteTarget(HttpServletRequest
request) {
boolean isFunctionsRestRequest = false;
String requestUri = request.getRequestURI();
- if (requestUri.startsWith("/admin/v2/functions")
- || requestUri.startsWith("/admin/functions")) {
+ // Functions workers handle function, sources, and sinks endpoints
+ if (requestUri.startsWith("/admin/v3/functions")
Review comment:
a better change might using regex to match "/admin/v*/functions",
"/admin/v*/sources" and "/admin/v*/sinks".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services