merlimat commented on a change in pull request #184: Dead letter queue
implementation
URL: https://github.com/apache/pulsar-client-go/pull/184#discussion_r379072208
##########
File path: pulsar/consumer_partition.go
##########
@@ -402,23 +404,27 @@ func (pc *partitionConsumer) MessageReceived(response
*pb.CommandMessage, header
var msg *message
if smm != nil {
msg = &message{
- publishTime:
timeFromUnixTimestampMillis(msgMeta.GetPublishTime()),
- eventTime:
timeFromUnixTimestampMillis(smm.GetEventTime()),
- key: smm.GetPartitionKey(),
- properties:
internal.ConvertToStringMap(smm.GetProperties()),
- topic: pc.topic,
- msgID: msgID,
- payLoad: payload,
+ publishTime:
timeFromUnixTimestampMillis(msgMeta.GetPublishTime()),
+ eventTime:
timeFromUnixTimestampMillis(smm.GetEventTime()),
+ key: smm.GetPartitionKey(),
+ properties:
internal.ConvertToStringMap(smm.GetProperties()),
+ topic: pc.topic,
+ msgID: msgID,
+ payLoad: payload,
+ replicationClusters: msgMeta.GetReplicateTo(),
Review comment:
We need to copy all properties of the original message and noticed that this
was not being exposed in the internal struct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
