sijie commented on a change in pull request #6310: Enable get precise backlog
and backlog without delayed messages.
URL: https://github.com/apache/pulsar/pull/6310#discussion_r379874810
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Subscription.java
##########
@@ -53,7 +53,7 @@ default void removeConsumer(Consumer consumer) throws
BrokerServiceException {
Dispatcher getDispatcher();
- long getNumberOfEntriesInBacklog();
+ long getNumberOfEntriesInBacklog(boolean isPreciseBacklog);
Review comment:
just a suggestion for future tasks:
if we are changing a method to add another flag, it would be better to add
an overloaded method rather than directly updating the original method. It will
reduce the number of files to be changed.
```
default long getNumberOfEntriesInBacklog() {
return getNumberOfEntriesInBacklog(false);
}
long getNumberOfEntriesInBacklog(boolean isPreciseBacklog);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
