EugenDueck commented on issue #6209: [broker] add feature BrokerDeduplicationAcrossProducers URL: https://github.com/apache/pulsar/pull/6209#issuecomment-586670841 @sijie @codelipenghui In terms of implementation, it would actually be simpler to allow multiple producers with the same name, if they have different producer groups. Otherwise, if we have producerGroups and unique producerNames across all groups, we need to have two hash maps (producers, and producerGroups), and we would need to coordinate access to both (e.g. via locking), two prevent concurrent calls to e.g. Topic.add(producer) from getting them out of sync. So unless there are objections, I'd like to change the uniqueness of producers from "producerName only" to "groupName and producerName".
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
