heronr opened a new pull request #6336: Windows CMake corrections
URL: https://github.com/apache/pulsar/pull/6336
 
 
   ### Motivation
   
   This change is to fix building with CMake on Windows platforms.
   
   ### Modifications
   
   The primary change is to provide more library names for zlib, protobuf, and 
curl that will match the windows versions of these libraries. It also includes 
small changes to find clang-format and clang-tidy, and also to install the dll 
in the bin folder instead of the lib folder.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to