addisonj edited a comment on issue #6347: PIP 57: Improve Zookeeper Session Timeout Handling URL: https://github.com/apache/pulsar/pull/6347#issuecomment-588004249 @codelipenghui I am dealing with an issues in the pulsar proxy where the list of brokers gets out of sync and requires a proxy restart. I came across this PR while investigating and while this doesn't fix some other issues in the proxy, I imagine it would help. However, I just noticed that there are two instances of `ZookeeperCacheLoader` that have almost the same contents, one is the instance you changed (`org.apache.pulsar.discovery.service.web.ZookeeperCacheLoader`) the other is for the proxy (`org.apache.pulsar.proxy.server.util.ZookeeperCacheLoader`). If we also want to alleviate some of these same issues for the proxy, we will need to either make the change in the proxy version as well OR just refactor to have them both share the class (not sure why it isn't doing it right now, it doesn't appear problematic)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
