devinbost opened a new pull request #6395: (Flaky-tests) Reduce flakiness of tests - attempt 3 URL: https://github.com/apache/pulsar/pull/6395 Branch of: https://github.com/apache/pulsar/pull/6202 (which is having weird Github Action CI issues and won't build my code changes anymore.) --- Increased test timeouts and made other changes to tests. Fixes https://github.com/apache/pulsar/issues/2647 Fixes https://github.com/apache/pulsar/issues/2651 Fixes https://github.com/apache/pulsar/issues/6014 Fixes https://github.com/apache/pulsar/issues/6198 Fixes https://github.com/apache/pulsar/issues/6224 Fixes https://github.com/apache/pulsar/issues/6232 Fixes https://github.com/apache/pulsar/issues/6254 Fixes https://github.com/apache/pulsar/issues/6256 Fixes https://github.com/apache/pulsar/issues/6299 Fixes https://github.com/apache/pulsar/issues/6304 Fixes https://github.com/apache/pulsar/issues/6306 Fixes https://github.com/apache/pulsar/issues/6352 Fixes other flaky tests that still need issues created for them. Master Issue: #6137 ### Motivation Need to resolve these flaky tests. ### Modifications 1. Fixes issues caused by test timeouts being too short. (The majority of changes in this PR are in this category.) 2. Fixes issues caused by hanging tests resulting from no timeouts. 3. Fixes Prometheus test issues (since these required more extensive changes to the tests.) There were multiple race conditions and concurrency issues in how we were getting data from Prometheus. (A more robust change would migrate our use of Prometheus to the new approach used in the Go Functions, but I don't think that change is necessary at this time.) 4. Changes that introduced awaitility library. (Only used in a couple of places to avoid the use of Thread.sleep.) 5. Fixes involving concurrency issues on topic names. (There were a few in this category.) Among other things, this PR fixes all issues like this: `java.lang.AssertionError: expected [val1-9] but found [val1-6]`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services